Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only create single-spa-container element when not using replaceMode #109

Merged
merged 2 commits into from
Jun 29, 2023
Merged

fix: only create single-spa-container element when not using replaceMode #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30ab5eb
fix: only create single-spa-container element when not using replaceMode
FelixGraf Apr 13, 2023
cc77f7a
style: format code with prettier
FelixGraf Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/single-spa-vue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,15 @@ function mount(opts, mountedInstances, props) {

if (!opts.replaceMode) {
appOptions.el = appOptions.el + " .single-spa-container";
}

// single-spa-vue@>=2 always REPLACES the `el` instead of appending to it.
// We want domEl to stick around and not be replaced. So we tell Vue to mount
// into a container div inside of the main domEl
if (!domEl.querySelector(".single-spa-container")) {
const singleSpaContainer = document.createElement("div");
singleSpaContainer.className = "single-spa-container";
domEl.appendChild(singleSpaContainer);
// single-spa-vue@>=2 always REPLACES the `el` instead of appending to it.
// We want domEl to stick around and not be replaced. So we tell Vue to mount
// into a container div inside of the main domEl
if (!domEl.querySelector(".single-spa-container")) {
const singleSpaContainer = document.createElement("div");
singleSpaContainer.className = "single-spa-container";
domEl.appendChild(singleSpaContainer);
}
}

instance.domEl = domEl;
Expand Down