(5.0): Refactoring navigateToUrl to reduce byte size #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#215515)DeepCode analyzed this pull request. |
frehner
reviewed
Dec 2, 2019
| singleSpaNavigate("#/route?yoshi=criminal"); | ||
| spyOn(window.history, "pushState"); | ||
| singleSpaNavigate("#/route?yoshi=freeanimal"); | ||
| expect(location.hash).toBe("#/route?yoshi=freeanimal"); |
| return uri; | ||
| const anchor = document.createElement("a"); | ||
| anchor.href = str; | ||
| return anchor; |
There was a problem hiding this comment.
wow this is quite the update
is an anchor tag the same return object shape as what was previously returned from this function?
There was a problem hiding this comment.
Not quite - path becomes pathname, etc. This accounts for the changes I made later on in the navigateToUrl function
| @@ -45,6 +45,7 @@ | |||
| "@babel/core": "^7.5.5", | |||
| "@babel/plugin-syntax-dynamic-import": "^7.2.0", | |||
| "@babel/preset-env": "^7.5.5", | |||
| "@rollup/plugin-replace": "^2.2.1", | |||
There was a problem hiding this comment.
shouldn't this come in addition to a change to the rollup config?
or was this just an accidental inclusion from another PR?
There was a problem hiding this comment.
Yeah good catch - this is for process.env.BABEL_ENV. I made the change to the rollup config but lost it in my frantic switching between branches. Will reinstate.
frehner
approved these changes
Dec 2, 2019
|
This technique could be used for dev/prod error messages. But I think better would be to use the technique described in https://github.com/facebook/react/tree/master/scripts/error-codes |
joeldenning
added a commit
that referenced
this pull request
Feb 23, 2020
* Adding prettier, speeding up pre-commit, and making clean script cross platform (#391) * Speeding up pre-commit, and making clean script cross platform * Adding prettier * Upgrading nodejs version in Travis (#394) * (5.0): Remove deprecated lifecycles (#390) * (5.0) Improving perf with babel/rollup changes (#392) * Improving perf with babel/rollup changes * Upgrading travis' node version * Removing babel-loader * (5.0): Reducing bundle size by removing class syntax (#393) * Avoiding classes to save bytes * Upgrading node version in travis * (5.0): Various refactors that improve performance (#396) * Various refactors that improve performance * Self review * Self review * (5.0): Refactoring navigateToUrl to reduce byte size (#395) * Refactoring navigateToUrl to reduce byte size * Anthony's feedback * should be functionally the same as it was before. (#403) but now with less duplication! * Switching to error codes for production single-spa (#400) * Switching to error codes for production single-spa * Self review * Self review * Self review * Self review * Self review * Self review * Anthony's feedback * Anthony's feedback * (5.0): Breaking - remove err.name and err.appName from thrown errors. (#404) * Switching to error codes for production single-spa * Self review * Self review * Self review * Self review * Self review * Self review * Anthony's feedback * Switching from name property to appOrParcelName * Self review * Adding support for warningMillis timeout config. Resolves #346. (#389) * Adding support for warningMillis timeout config. Resolves #346. * Self review * Adding more tests, and self review * Excluding failing tests temporarily * Linter errors * Self review * Tests * Self review * Self review * Fixing tests * Uncommenting fit * Updating link to error codes (#406) * Switching from object rest spread to manual assign. (#401) * Switching from object rest spread to manual assign. * More assigns * Self review * Prototype pollution * Self review * Self review * Small updates to parcel-related errors (#407) * Small updates to parcel-related errors * Self review * v5.0.0-beta.0 * Adding banner comment to output bundles (#409) * Adding banner comment to output bundles * Self review * Improving description and keywords (#410) * v5.0.0-beta.1 * Small improvements to error messages (#423) * Migrating references of CanopyTax org to single-spa Co-authored-by: Anthony Frehner <frehner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Two perf things here:
opts, and used @rollup/plugin-replace to remove the code that only exists for testsparseUriandnavigateToUrlto use browser anchor tags instead of the 3p lib that was pasted in earlier.