New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to error codes for production single-spa #400
Conversation
DeepCode Report (#4abd52)DeepCode analyzed this pull request. |
This is ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but once it's fixed then feel free to merge.
export function formatErrorMessage(code, msg, ...args) { | ||
return `single-spa minified message #${code}: ${ | ||
msg ? msg : "" | ||
}See https://single-spa.js.org/error?code=${code}${ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there won't be a space between the message and See
will there?
* Adding prettier, speeding up pre-commit, and making clean script cross platform (#391) * Speeding up pre-commit, and making clean script cross platform * Adding prettier * Upgrading nodejs version in Travis (#394) * (5.0): Remove deprecated lifecycles (#390) * (5.0) Improving perf with babel/rollup changes (#392) * Improving perf with babel/rollup changes * Upgrading travis' node version * Removing babel-loader * (5.0): Reducing bundle size by removing class syntax (#393) * Avoiding classes to save bytes * Upgrading node version in travis * (5.0): Various refactors that improve performance (#396) * Various refactors that improve performance * Self review * Self review * (5.0): Refactoring navigateToUrl to reduce byte size (#395) * Refactoring navigateToUrl to reduce byte size * Anthony's feedback * should be functionally the same as it was before. (#403) but now with less duplication! * Switching to error codes for production single-spa (#400) * Switching to error codes for production single-spa * Self review * Self review * Self review * Self review * Self review * Self review * Anthony's feedback * Anthony's feedback * (5.0): Breaking - remove err.name and err.appName from thrown errors. (#404) * Switching to error codes for production single-spa * Self review * Self review * Self review * Self review * Self review * Self review * Anthony's feedback * Switching from name property to appOrParcelName * Self review * Adding support for warningMillis timeout config. Resolves #346. (#389) * Adding support for warningMillis timeout config. Resolves #346. * Self review * Adding more tests, and self review * Excluding failing tests temporarily * Linter errors * Self review * Tests * Self review * Self review * Fixing tests * Uncommenting fit * Updating link to error codes (#406) * Switching from object rest spread to manual assign. (#401) * Switching from object rest spread to manual assign. * More assigns * Self review * Prototype pollution * Self review * Self review * Small updates to parcel-related errors (#407) * Small updates to parcel-related errors * Self review * v5.0.0-beta.0 * Adding banner comment to output bundles (#409) * Adding banner comment to output bundles * Self review * Improving description and keywords (#410) * v5.0.0-beta.1 * Small improvements to error messages (#423) * Migrating references of CanopyTax org to single-spa Co-authored-by: Anthony Frehner <frehner@users.noreply.github.com>
Before:
After: