Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#46] Add support for MongoDB indexes #152

Merged
merged 9 commits into from
Jul 10, 2024
Merged

[#46] Add support for MongoDB indexes #152

merged 9 commits into from
Jul 10, 2024

Conversation

eddiebrissow
Copy link
Collaborator

@eddiebrissow eddiebrissow commented Jul 5, 2024 •
edited
Loading

closes das#46

Added support to:

  • MongoDB text index
  • MongoDB Compound index
  • Query node name starting with
  • Added explain to integration tests

Changes to public API:

  • New methods
    • get_atoms_by_field
    • get_atoms_by_index
    • get_node_by_name_starting_with
  • Signature changes
    • create_field_index
  • Name change
    • get_matched_node_name -> get_node_by_name

angeloprobst
angeloprobst previously requested changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@angeloprobst angeloprobst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments regarding code style.
The rationale is to avoid too long lines for a better readability.

hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
andre-senna
andre-senna requested changes Jul 5, 2024
View reviewed changes
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/database.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/database.py Outdated Show resolved Hide resolved
@angeloprobst angeloprobst dismissed their stale review July 9, 2024 15:18

changes applied

@angeloprobst angeloprobst self-requested a review July 9, 2024 15:18
angeloprobst
angeloprobst requested changes Jul 9, 2024
View reviewed changes
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/adapters/redis_mongo_db.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/database.py Outdated Show resolved Hide resolved
hyperon_das_atomdb/database.py Outdated Show resolved Hide resolved
@andre-senna andre-senna self-requested a review July 9, 2024 18:34
andre-senna
andre-senna reviewed Jul 9, 2024
View reviewed changes
hyperon_das_atomdb/adapters/redis_mongo_db.py
def create(
self,
atom_type: str,
field: str,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in #153

@eddiebrissow eddiebrissow merged commit 9cbf56b into master Jul 10, 2024
1 check passed
@eddiebrissow eddiebrissow deleted the imp/issue-46-das-mongodb-indexes branch July 10, 2024 17:11
@eddiebrissow eddiebrissow mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-senna andre-senna andre-senna requested changes

@angeloprobst angeloprobst angeloprobst requested changes

@marcocapozzoli marcocapozzoli marcocapozzoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eddiebrissow @andre-senna @angeloprobst @marcocapozzoli