-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish state_service.proto in release artifacts #99
Comments
all proto files used by Daemon will be moved to an Artifact ( proto files will be downloaded from this artifact ) to an folder in Daemon called proto and referenced accordingly |
@anandrgitnirman is this completed? Can we close the issue |
@anandrgitnirman, I don't see |
will share the details once done, will raise a PR for review , this is work in progress |
Ok, got it, read it inaccurately first time |
all protos are now published as part of Daemon release [v0.1.10] (https://github.com/singnet/snet-daemon/releases/tag/v0.1.10) and any future releases |
do we have a script to create release artifacts? |
Yes, its an AWS code build. It also sets the version in the daemon before the build and tags the release in Github as well. |
I think it makes sense to add this code into repo as well. Or may be it is already on github, but located in other repo? |
Yes, this is part of the infrastructure repo which is private.
…On Thu, Apr 4, 2019, 14:19 Vitaly Bogdanov ***@***.***> wrote:
I think it makes sense to add this code into repo as well. Or may be it is
already on github, but located in other repo?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ApymOWV3jVxO3_gMJGJQX3SygZLAgRXTks5vdbyWgaJpZM4X7s0p>
.
|
Any reason why this script cannot be added to this one? |
No particular reason except that we wanted to keep all infra related scripts in one place rather than have it distributed across repos, easier to manage them. |
Ah ok, may be it doesn't matter for now. |
state_service.proto
is used by snet-daemon client to get information about payment channels.It is a part of snet-daemon API and it should be published in release artifacts.
The text was updated successfully, but these errors were encountered: