Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish state_service.proto in release artifacts #99

Closed
vsbogd opened this issue Oct 26, 2018 · 13 comments
Closed

Publish state_service.proto in release artifacts #99

vsbogd opened this issue Oct 26, 2018 · 13 comments
Labels
enhancement New feature or request

Comments

@vsbogd
Copy link
Member

vsbogd commented Oct 26, 2018

state_service.proto is used by snet-daemon client to get information about payment channels.
It is a part of snet-daemon API and it should be published in release artifacts.

@ghost
Copy link

ghost commented Jan 18, 2019

all proto files used by Daemon will be moved to an Artifact ( proto files will be downloaded from this artifact ) to an folder in Daemon called proto and referenced accordingly
Snet-cli wiill also download from this artifact

@ghost ghost removed the beta label Jan 21, 2019
@raamb
Copy link
Member

raamb commented Mar 20, 2019

@anandrgitnirman is this completed? Can we close the issue

@vsbogd
Copy link
Member Author

vsbogd commented Mar 20, 2019

@anandrgitnirman, I don't see .proto files in released artifacts? Could you please clarify which artifact do you mean?

@anandrgitnirman
Copy link
Contributor

will share the details once done, will raise a PR for review , this is work in progress

@vsbogd
Copy link
Member Author

vsbogd commented Mar 25, 2019

Ok, got it, read it inaccurately first time

@anandrgitnirman
Copy link
Contributor

all protos are now published as part of Daemon release [v0.1.10] (https://github.com/singnet/snet-daemon/releases/tag/v0.1.10) and any future releases
you will find the files under the directory /proto

@vsbogd
Copy link
Member Author

vsbogd commented Apr 4, 2019

do we have a script to create release artifacts?

@raamb
Copy link
Member

raamb commented Apr 4, 2019

Yes, its an AWS code build. It also sets the version in the daemon before the build and tags the release in Github as well.

@vsbogd
Copy link
Member Author

vsbogd commented Apr 4, 2019

I think it makes sense to add this code into repo as well. Or may be it is already on github, but located in other repo?

@raamb
Copy link
Member

raamb commented Apr 4, 2019 via email

@vsbogd
Copy link
Member Author

vsbogd commented Apr 4, 2019

Any reason why this script cannot be added to this one?

@raamb
Copy link
Member

raamb commented Apr 5, 2019

No particular reason except that we wanted to keep all infra related scripts in one place rather than have it distributed across repos, easier to manage them.

@vsbogd
Copy link
Member Author

vsbogd commented Apr 5, 2019

Ah ok, may be it doesn't matter for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants