Initial draft for alpha release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use config object instead of env Improvements to Account
vsbogd
reviewed
May 14, 2019
vsbogd
reviewed
May 14, 2019
vsbogd
reviewed
May 14, 2019
vsbogd
reviewed
May 14, 2019
raamb
reviewed
May 15, 2019
raamb
reviewed
May 15, 2019
raamb
approved these changes
May 21, 2019
src/payment_channel_management_strategies/PaymentChannelManagementStrategy.js
Outdated
Show resolved
Hide resolved
vsbogd
reviewed
May 22, 2019
… offset and call allowance
vsbogd
approved these changes
May 24, 2019
vsbogd
reviewed
May 24, 2019
| @@ -0,0 +1,61 @@ | |||
| import { find } from 'lodash'; | |||
|
|
|||
| export default class DefaultPaymentChannelManagementStrategy { | |||
There was a problem hiding this comment.
I would also add interface to implement custom strategy - not sure if interfaces are common in JS, thogh :-)
There was a problem hiding this comment.
Yeah, this would be communicated with api docs which would be made available soon.
chetankothari
force-pushed
the
1.0.0-alpha
branch
from
6e01386
to
bf675e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing things that need to be improved or addressed
I have added a simple example file which tries to invoke example calculator service. code.Sample usage has been added to snet-code-examples which can be easily tried out locally.
Need help with identifying the correctness of all the operations and corner cases if I have missed any. I feel we can do better with the design and happy to hear suggestions if any.