-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix services user id registration / removal #108
Conversation
2a1c690
to
6b81f56
Compare
@SingaporeClouds The PR includes some rule changes that will prevent old client to add a services. The rules enforce a service user id is only used by one user. To add a service:
We should probably go through each profile and remove service when the user id is shared and add the user id claims otherwise. * id and name are currently the same value but AFAIK code combat profile have a user name, shown in the code combat profile page and a user id, used to query achievements; We could ask the user a code combat user name and convert it to a user id. |
There is no reason to prevent users from claiming the same username on a 3rd party service at this point in time. Everyone's username for each service is shown on their profile page, so anyone could quickly determine if someone was using a username that wasn't theirs. Also, if someone accidentally claims someone else's username on Code Combat or FreeCodeCamp by accident (or intentionally), the actual username owner would then be unable to claim their username. The downside of handling these potential disputes at scale is currently greater than the benefit of preventing multiple users from using the same 3rd party username. Therefore, please leave out any rules or mechanisms that try to prevent multiple users from trying to claim the same 3rd party service username. |
3a525e5
to
dbb2934
Compare
9e5b196
to
1d4cac4
Compare
3b87a61
to
0a31d68
Compare
0a31d68
to
ca1eaa1
Compare
ca1eaa1
to
582f0f0
Compare
- removed dead code from profile component; - refactor service cards into a component - move service registration logic out of the profile controller; - automatically create service update task when adding a service.
582f0f0
to
6f766b8
Compare
TODO: