Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear that the default won't work with gpus #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

surak
Copy link
Contributor

@surak surak commented Aug 1, 2022

No description provided.

Copy link
Contributor Author

@surak surak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that one has to actively push to have gpu support, as it seemed obvious.

@@ -276,7 +276,7 @@ supports gpu":
gpu: true

Given that you are installing a module for a Singularity container, the ``--nv``
option will be added. Currently, the following features are supported:
option will be added IF the container_features is also set - the default is ``null``. Currently, the following features are supported:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say something like:

By default, container_features in your settings.yaml is unset, meaning that you will not enable any kind of gpu features for containers. You will need to set this feature to something non-null in your settings.yaml to enable features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants