Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/messages #132

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Fix/messages #132

merged 3 commits into from
Jun 5, 2018

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Jun 4, 2018

@victorsndvg does this ok to resolve the remaining issues?

@vsoch vsoch mentioned this pull request Jun 5, 2018
@victorsndvg
Copy link
Contributor

mmmm

Hi @vsoch, it seems that there is no request in some scopes. Maybe it has to be passed as an argument to some functions? or maybe I'm missing something?

Look at this lines:

messages.info(request, '%s is removed from %s' %(user.username, team.name))

messages.info(request, '%s is no longer owner of %s' %(user.username, team.name))

messages.info(request, 'At least one owner must be present for a team.')

@vsoch
Copy link
Member Author

vsoch commented Jun 5, 2018

Ah, this is because the first "fix" to add the request was wrong to begin with! Those underscore (private) functions don't return directly to views, and the messages being there was legacy from when they returned json response. The messages shouldn't be there because they don't return to a view, and requests shouldn't be defined / used in the functions at all.

@victorsndvg
Copy link
Contributor

Perfect, working! 👍

@vsoch
Copy link
Member Author

vsoch commented Jun 5, 2018

Awesome!

@vsoch vsoch merged commit 44d36a8 into master Jun 5, 2018
@vsoch vsoch deleted the fix/messages branch March 24, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants