Add JSDoc to public properties #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 79 79
=====================================
Hits 79 79
Continue to review full report at Codecov.
|
mgred
approved these changes
Feb 12, 2020
|
LGTM, although the linter is failing the build ☝️👮 |
This adds linting of jsdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JSDoc comments to all public properties
It has been validated using the configuration in sinonjs/eslint-config#6, with the instructions in that PR.
Before this PR can go green, the following needs to happen:
eslint-config-sinonin this branch needs to be bumped