Skip to content

Commit

Permalink
Bump handlebars from 4.4.5 to 4.7.6
Browse files Browse the repository at this point in the history
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.5 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.4.5...v4.7.6)

Signed-off-by: dependabot[bot] <support@github.com>
  • Loading branch information
dependabot[bot] authored and mroderick committed Sep 10, 2020
1 parent 8bedb32 commit 38a9030
Showing 1 changed file with 12 additions and 29 deletions.
41 changes: 12 additions & 29 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 comments on commit 38a9030

@fatso83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed our builds in :

safari 9.0
ie 11
firefox

Found out when trying to release and running ci builds. Reverting.

@fatso83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, screw that, that build broke on June 8th! This commit has nothing to do with it, which makes sense, since I had no idea why handlebars would break stacktraces.

See https://github.com/sinonjs/fake-timers/commits/master

@mroderick
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps @benjamingr has time to investigate it?

@fatso83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was pretty clear what caused it when looking at the PR and the tests that broke, so that PR has been reverted :)

Please sign in to comment.