Copy all property descriptors to installed methods #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The for...in loop would copy only string own-properties to installed methods, which would omit util.promisify.custom necessary for util.promisify support on Node as added in sinonjs#292. Instead, copy all own-property descriptors to get both Symbol own-properties and to copy any getters/setters that may be added in the future. Add tests for util.promisify behavior. Fixes: sinonjs#347 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 93.15% 93.12% -0.03%
==========================================
Files 1 1
Lines 555 553 -2
==========================================
- Hits 517 515 -2
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
benjamingr
approved these changes
Jan 13, 2021
|
I don't know why this has been dormant for five months, but I see @benjamingr approved it, so I guess it's good. Just merge it the next time, Benjamin, unless there's something specific you want a second pair of eyes on (in which case you just ping that someone) 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix #347 by copying symbol own-properties to installed methods.
Background (Problem in detail) - optional
The
for...inloop used to copy properties only copies string own-properties to installed methods, which omitsutil.promisify.customnecessary forutil.promisifysupport on Node as added in #292.Solution - optional
This PR copies all own-property descriptors to get both
Symbolown-properties and to copy any getters/setters that may be added in the future.If there's a reason getters/setters should not be copied, let me know and I can add an
Object.assignpolyfill to sinonjs/commons and use that instead.Thanks for considering,
Kevin
Fixes: #347