unmaintained 'text-encoding'

[gms1]

the dependency 'text-encoding' of 'nise' is no longer maintained:

gms@orion:~/work/RESEARCH/loopback4-example-todo$ npm i
npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm notice created a lockfile as package-lock.json. You should commit this file.
added 623 packages from 1418 contributors and audited 3053 packages in 19.523s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details

gms@orion:~/work/RESEARCH/loopback4-example-todo$ npm ls text-encoding
@loopback/example-todo@0.21.2 /home/gms/work/RESEARCH/loopback4-example-todo
└─┬ @loopback/testlab@0.15.1
  └─┬ sinon@6.3.5
    └─┬ nise@1.4.5
      └── text-encoding@0.6.4 

[mroderick]

Thank you for the heads up.

I guess we'll have find a suitable replacement, or incorporate parts of the original work into this repository.

[soodsagar]

This is still an issue :/

[fatso83]

Could we include it under our umbrella of projects?

[mroderick]

If we can talk the owner of the repository and npm to transfer ownership, then I guess we can.

[mantoni]

Alternatively we can publish a fork under the @sinonjs namespace.

[mroderick]

Alternatively we can publish a fork under the @sinonjs namespace.

Let's just do that

[MichaelDeBoey]

Any news on this one?

[gms1]

@mroderick

incorporate parts of the original work into this repository.

This API is available in Node.js 8.x and this polyfill is only needed to support older versions.
So I would suggest copying the file from here
https://github.com/inexorabletash/text-encoding/blob/master/lib/encoding.js
and use either the shim or the internal API depending on the node version

[mroderick]

This API is available in Node.js 8.x and this polyfill is only needed to support older versions.

... and browsers.

All the Sinon projects support IE11 and Edge.

https://caniuse.com/#search=TextEncoder

[gms1]

is not a problem or is it?

if (typeof TextEncoder === 'undefined') {
   require ("./path/to/local/text-encoder-shim");
}

[hueniverse]

Any update on this? Anything I can do to help?

[fatso83]

@hueniverse Just supply a PR with that copies the file into the repo and require it on demand - something like @gms1 suggested. Easy peasy.

Nevermind, @cibernox has created #80

[fatso83]

nise 1.4.10 and sinon 7.2.4