Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #253

Merged
merged 9 commits into from
Dec 27, 2023
Merged

Update dependencies #253

merged 9 commits into from
Dec 27, 2023

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Dec 22, 2023

Purpose (TL;DR) - mandatory

  • Upgrade Sinon project dependencies
  • Update all tooling dependencies
  • Upgrade prettier to v3 and reformat all files
  • Drop support for node 14, add node 20 to the build matrix

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm run lint
  4. npm test
  5. npm run build

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

Copy link
Member

@mroderick mroderick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using lts/* for node-version, we don't need need to keep updating these lines.

See https://github.com/actions/setup-node#supported-version-syntax

There is one use of actions/setup-node@v2 where I couldn't make a suggestion for using v4 in the GitHub UI.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1f8eb4) 100.00% compared to head (e710b9d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           81        81           
  Lines          666       666           
=========================================
  Hits           666       666           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mantoni
Copy link
Member Author

mantoni commented Dec 27, 2023

@mroderick Thanks! There's always a little thing to learn every day 🧑‍🎓

@mantoni mantoni merged commit 14949b9 into main Dec 27, 2023
7 checks passed
@mantoni mantoni deleted the update-dependencies branch December 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants