Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor is*Error tests #85

Merged
merged 5 commits into from
Jan 30, 2019
Merged

Refactor is*Error tests #85

merged 5 commits into from
Jan 30, 2019

Conversation

mroderick
Copy link
Member

This PR is part of the ongoing effort to refactor the tests to use plain Mocha, and remove the difficult to understand test helper.

How to verify - mandatory

  1. Check out this branch
  2. npm ci
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 281

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 280: 0.0%
Covered Lines: 652
Relevant Lines: 652
💛 - Coveralls

mantoni
mantoni approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mantoni
Copy link
Member

mantoni commented Jan 30, 2019

Sorry, this fell through the cracks 😊

@mroderick mroderick merged commit 557ec80 into sinonjs:master Jan 30, 2019
@mroderick
Copy link
Member Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantoni mantoni mantoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mroderick @coveralls @mantoni