Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @sinonjs/samsam to v3.3.0 for symbol property support #94

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Mar 8, 2019

Purpose (TL;DR) - mandatory

This updates samsam to v3.3.0 to add symbol property support and fixes the related test cases.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm t

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mantoni mantoni requested a review from mroderick March 8, 2019 09:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 313

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 310: 0.0%
Covered Lines: 659
Relevant Lines: 659

💛 - Coveralls

@mantoni mantoni added this to the 4.0 milestone Mar 8, 2019
@mantoni mantoni merged commit 574839a into master Mar 9, 2019
@mroderick mroderick deleted the samsam-v3.3 branch March 9, 2019 15:31
@mroderick
Copy link
Member

Cut a new minor version?

@mantoni
Copy link
Member Author

mantoni commented Mar 9, 2019

It's implicitly coming with a fresh install for users, so no need for a release really. Other than that I wanted to release 4.0.0 with the removed defined API and failing when equals is given undefined (#87).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants