Merge dc06f0c into 6753803

sinonjs · Dec 9, 2018 · d727f26 · d727f26
2 parents 6753803 + dc06f0c
commit d727f26
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/lib/deep-equal.js b/lib/deep-equal.js
@@ -98,13 +98,7 @@ function deepEqualCyclic(first, second, match) {
         }
 
         if (obj1 instanceof Error && obj2 instanceof Error) {
-            if (
-                obj1.constructor !== obj2.constructor ||
-                obj1.message !== obj2.message ||
-                obj1.stack !== obj2.stack
-            ) {
-                return false;
-            }
+            return obj1 === obj2;
         }
 
         var class1 = getClass(obj1);

diff --git a/lib/deep-equal.test.js b/lib/deep-equal.test.js
@@ -475,6 +475,13 @@ describe("deepEqual", function() {
         assert.equals(el.childNodes.length, 0);
     });
 
+    it("fails unequal errors", function() {
+        var error1 = new Error();
+        var error2 = new Error();
+
+        assert.isFalse(samsam.deepEqual(error1, error2));
+    });
+
     if (typeof Set !== "undefined") {
         it("returns true if set with the same content", function() {
             var checkDeep = samsam.deepEqual(