Fix stub id prefix

sinonjs · May 7, 2018 · c13bea3 · c13bea3
1 parent c0eb019
commit c13bea3
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/lib/sinon/stub.js b/lib/sinon/stub.js
@@ -105,8 +105,8 @@ var proto = {
         };
 
         var orig = functionStub;
-        functionStub.id = "stub#" + uuid++;
         functionStub = spy.create(functionStub, stubLength);
+        functionStub.id = "stub#" + uuid++;
         functionStub.func = orig;
 
         extend(functionStub, stub);

diff --git a/test/spy-test.js b/test/spy-test.js
@@ -2783,5 +2783,13 @@ describe("spy", function () {
             ]);
         });
     });
+
+    describe(".id", function () {
+        it("should start with 'spy#'", function () {
+            for (var i = 0; i < 10; i++) {
+                assert.isTrue(createSpy().id.indexOf("spy#") === 0);
+            }
+        });
+    });
 });
 
diff --git a/test/stub-test.js b/test/stub-test.js
@@ -2961,4 +2961,12 @@ describe("stub", function () {
             assert.equals(myObj.prop, "newString");
         });
     });
+
+    describe(".id", function () {
+        it("should start with 'stub#'", function () {
+            for (var i = 0; i < 10; i++) {
+                assert.isTrue(createStub().id.indexOf("stub#") === 0);
+            }
+        });
+    });
 });