Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noisy output in donations message #1742

Merged
merged 3 commits into from
Mar 21, 2018

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Mar 21, 2018

Purpose

  • Basically get's rid of most of the echoed console.log noise.
  • Minor change in the wording 🙏

Don't think this is much different from the oneliner performance wize (ref #1737).

How to verify - mandatory

  1. npm run postinstall

Basically just replaces this
> sinon@4.4.6 postinstall /home/carlerik/dev/sinon
> node -e "console.log('\u001b[32mLove sinon? You can now support the project via the open collective:\u001b[22m\u001b[39m\n > \u001b[96m\u001b[1mhttps://opencollective.com/sinon/donate\u001b[0m\n')" || exit 0

with this
> sinon@4.4.6 postinstall /home/carlerik/dev/sinon
> node scripts/support-sinon.js
@fatso83 fatso83 requested a review from mroderick March 21, 2018 14:26
@mroderick mroderick merged commit 9fb8577 into sinonjs:master Mar 21, 2018
@mroderick
Copy link
Member

This has been published as sinon@4.4.7 ❤️

@fatso83 fatso83 deleted the reduce-donations-noise branch September 23, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants