Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved linting for staged files #1480

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Improved linting for staged files #1480

merged 2 commits into from
Jul 4, 2017

Conversation

fearphage
Copy link
Member

I replaced the external script with lint-staged. Now you don't get eslint --help when you commit non-js file changes. 馃殌

@coveralls
Copy link

coveralls commented Jul 3, 2017 •
edited

Coverage Status

Coverage remained the same at 94.998% when pulling f07215e on fearphage:lint-staged into 079925b on sinonjs:master.

@sinonjs sinonjs deleted a comment from coveralls Jul 3, 2017
@mantoni
Copy link
Member

mantoni commented Jul 3, 2017

What is "husky" doing?

@mantoni
Copy link
Member

mantoni commented Jul 3, 2017

Ah, ok, got it. I have no objections :)

@fatso83 fatso83 merged commit 1108117 into sinonjs:master Jul 4, 2017
@fearphage fearphage deleted the lint-staged branch July 4, 2017 16:52
@mroderick
Copy link
Member

If you get this warning when committing:

.git/hooks/pre-commit: line 2: ./node_modules/pre-commit/hook: No such file or directory

Then you will need to remove the old hook from pre-commit:

rm .git/hooks/pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fearphage @coveralls @mantoni @mroderick @fatso83