Append named exports to the generated esm bundle #1835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
This pull request will add named exports to the ESM bundle to allow parts of sinon to be imported like this:
It fixes issue ##1833.
As a byproduct it will also equalize the following to import statements:
It works by appending all named exports to the bundle generated by rollup. With the current API the following code block gets appended:
How to verify - mandatory
npm install
npm run build
Checklist for author
npm run lint
passes