Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section for obtaining sinon access #1895

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Add section for obtaining sinon access #1895

merged 1 commit into from
Sep 7, 2018

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Sep 7, 2018

Purpose (TL;DR) - mandatory

It is currently not spelled out how to obtain sinon in Node or the browser.

As with sinon-test, let me know if you want to also switch from var to let/const

How to verify - mandatory

  1. Look at the docs

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@coveralls
Copy link

coveralls commented Sep 7, 2018 •
edited

Pull Request Test Coverage Report for Build 2651

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.331%
Totals Coverage Status
Change from base Build 2649: 0.0%
Covered Lines: 2034
Relevant Lines: 2088
💛 - Coveralls

fatso83
fatso83 requested changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, apart from my one comment.

docs/index.md Outdated
#### Node and CommonJS build systems

```javascript
const sinon = require('sinon');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use var here. We are targetting ES5 engines, which don't support that syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha... Fixed...

@brettz9
Add section for obtaining sinon access
0f0534c 
As with sinon-test, let me know if you want to also switch from `var` to `let`/`const`
@fatso83 fatso83 merged commit 72bb35e into sinonjs:master Sep 7, 2018
@fatso83
Copy link
Contributor

fatso83 commented Sep 7, 2018

Thanks!

franck-romano pushed a commit to franck-romano/sinon that referenced this pull request Oct 1, 2019
@brettz9
Add section for obtaining sinon access using script tags (sinonjs#1895
017425a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brettz9 @coveralls @fatso83