Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rollup #2127

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Remove rollup #2127

merged 1 commit into from
Oct 6, 2019

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Oct 6, 2019

Purpose (TL;DR) - mandatory

Replace rollup with a Browserify based solution so that we depend on one bundler instead of two.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm t
  4. Observe that all tests still pass

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mroderick mroderick merged commit 1c607a2 into master Oct 6, 2019
@mroderick mroderick deleted the remove-rollup branch October 6, 2019 08:11
@mantoni mantoni mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroderick mroderick mroderick approved these changes

@fatso83 fatso83 Awaiting requested review from fatso83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mantoni @mroderick