Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning API or update Jade and corresponding tests for 1.0.2 #27

Closed
wants to merge 1 commit into from

Conversation

kennethormandy
Copy link
Collaborator

Jade deprecated !!! for doctype in 1.0.0, which is unfortunate. It was also decided not to make it a warning, like with script., but to actually throw an error.

I don’t necessarily think this should get merged, but we’ll have to deal with it at some point. It’s going to break every app written in Jade since we were advocating the !!! shorthand over doctype (I didn’t even know that was shorthand, to be honest).

If anything, it might indicate we need some way to throw our own warning pages, just like we do for errors. Then, when breaking API changes happen again, either in Harp like with _data, or in the preprocessors, like when LESS stopped working with Bootstrap 2 one, this issue, or whatever else, Harp could fail more gracefully. It would actually also be great for missing libsass features, too.

@sintaxi
Copy link
Owner

sintaxi commented Jan 7, 2014

Wrote a fix and have a PR pending at pugjs/pug#1374.

@buschtoens
Copy link

I recommend adding a try { ... } catch(err) { ... } or manual input file checking for the time being.
The users will have to adapt to this change.
!!! is counter-intuitive, ambigious and was a bad idea in the first place. There are at least 4 other breaking changes, so updating everything in one go is easier for the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants