Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings refactor #161

Merged
merged 10 commits into from
May 8, 2023
Merged

Settings refactor #161

merged 10 commits into from
May 8, 2023

Conversation

etiaro
Copy link
Contributor

@etiaro etiaro commented Mar 16, 2023

Resolves #160

@etiaro etiaro requested a review from twalen as a code owner March 16, 2023 21:45
@etiaro etiaro marked this pull request as draft March 16, 2023 21:45
LiquidPL
LiquidPL reviewed Mar 17, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@etiaro etiaro marked this pull request as ready for review March 29, 2023 17:41
twalen
twalen reviewed Apr 3, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
twalen
twalen reviewed Apr 3, 2023
View reviewed changes
oioioi/default_settings.py Outdated Show resolved Hide resolved
twalen
twalen requested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've added small comments, but once they are resolved we can merge this..

@etiaro etiaro requested a review from twalen April 15, 2023 13:00
@etiaro etiaro marked this pull request as draft April 17, 2023 21:11
@etiaro etiaro marked this pull request as ready for review April 19, 2023 21:35
twalen
twalen reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rosolve the merge conflict and we can merge it

@etiaro etiaro requested a review from twalen April 24, 2023 21:31
twalen
twalen previously approved these changes May 8, 2023
View reviewed changes
@etiaro etiaro merged commit 04c94c2 into sio2project:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiquidPL LiquidPL LiquidPL left review comments

@twalen twalen twalen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings refactor
5 participants
@etiaro @LiquidPL @twalen @edokimok @pzurakowski