Add NODE_P2P_V2 to filters #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming modern node software won't need pre-segwit peers or bloom filters, these combinations have been omitted.
43 tasks
|
ACK b9c64db |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps premature since bitcoin/bitcoin#24545 hasn't been merged yet, but I figured it would be handy if at least one seed supports it. Mine does now, only on mainnet:
xc08.seed.bitcoin.sprovoost.nlall SegWit enabled nodes including pruned onesx809.seed.bitcoin.sprovoost.nlall SegWit enabled full archive nodes (needed for IBD)x849for full archive nodes (orxc48, but Bitcoin Core only serves these filters on pruned nodes if they've been enabled since IBD, see Improve Indices on pruned nodes via prune blockers bitcoin/bitcoin#21726)So far it's found one reachable node on IPv4.
Usage (IPv4 vs IPv6, results under
ANSWER SECTION):Assuming modern node software won't need pre-segwit peers or bloom filters, these combinations have been omitted.
Someone should sanity check the hex values.