Save database upon graceful exit #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzen
force-pushed
the
update-dnsseed-exit
branch
from
da0571b
to
61bd1de
Compare
CaveSpectre11
suggested changes
Dec 8, 2019
peterzen
force-pushed
the
update-dnsseed-exit
branch
from
efc88a1
to
e0cb26c
Compare
peterzen
force-pushed
the
update-dnsseed-exit
branch
from
e0cb26c
to
13c67de
Compare
sipa
reviewed
Dec 17, 2020
| @@ -334,39 +334,58 @@ int StatCompare(const CAddrReport& a, const CAddrReport& b) { | |||
| } | |||
| } | |||
|
|
|||
| bool isDumpDbRunning = false; | |||
There was a problem hiding this comment.
I don't believe this function is signal safe: https://man7.org/linux/man-pages/man7/signal-safety.7.html
In particular, it indirectly performs memory allocations. Generally the approach is setting just a flag in the handler itself, and having a main processing thread detect the flag and process it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dump dnsseed.dat on SIGINT
Solves #76