tests for Cut block #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| describe('open/close', function() { | ||
| it('should show/hide container on open/close', function() { | ||
| var container = cut.getContainer(), | ||
| containerClass = 'cut__container_visible'; |
There was a problem hiding this comment.
такого делать не нужно. Нужно брать "честное" состояние элемента
|
сосквошь коммиты |
gruzzilkin
force-pushed
the
feature-cut
branch
2 times, most recently
from
bb398e3
to
b54702f
Compare
gruzzilkin
force-pushed
the
feature-cut
branch
from
b54702f
to
d7706ac
Compare
|
Первый раз сквошил коммиты, похерил в итоге историю ^_^ Надеюсь, в этом нет ничего страшного, остальные твои замечания исправил. |
| * @module cut | ||
| */ | ||
|
|
||
| modules.define('cut', ['button'], function(provide, _, Cut) { |
There was a problem hiding this comment.
Что нужно сделать, чтобы заставить работать код из этого файла? У меня кончились варианты.
There was a problem hiding this comment.
так ты ж этот модификатор ен указал нигде - ни в bemjson, ни в deps. В зависимостях у тебя вообще указан элемент switcher, которого не существует
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests and fix example. Actualization of the branch.