Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies + rebuild using svd2rust 0.28.0 #16

Merged
merged 5 commits into from
Feb 18, 2023

Conversation

jspngh
Copy link
Contributor

@jspngh jspngh commented Feb 18, 2023

  • update the dependencies to their latest version.
  • increase the MSRV to 1.59 and update the CI accordingly
  • rebuild the code with latest svd2rust

@jspngh
Copy link
Contributor Author

jspngh commented Feb 18, 2023

Hmm, not sure why this is failing.

@9names
Copy link
Collaborator

9names commented Feb 18, 2023

Me either - the CI scripts are a bit old and haven't run in a while unfortunately.
Looks like the cargo cache is stale so it can't find the package. I wonder if we can manually update it...

@9names
Copy link
Collaborator

9names commented Feb 18, 2023

Nope. Looks like it will work if you don't try to build for 1.59. something is up with the matrix action.
And we need to remove svdconv for it to work as well since that URL is broken.
Anyway: I've tested with those changes at #17 and it's passing.

@9names
Copy link
Collaborator

9names commented Feb 18, 2023

Would you mind if I brought those changes across into this branch?

@jspngh
Copy link
Contributor Author

jspngh commented Feb 18, 2023

Go ahead! Do you need permission on my repo for that?

@9names
Copy link
Collaborator

9names commented Feb 18, 2023

Nope, maintainers automatically have permission to edit for PRs - maybe for forks, too.

Copy link
Collaborator

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@9names 9names merged commit 33c3e3d into sipeed:main Feb 18, 2023
@9names 9names mentioned this pull request Feb 18, 2023
@jspngh jspngh deleted the update_dependencies branch February 18, 2023 13:50
@9names 9names mentioned this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants