-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved editbox sizing #37
Conversation
The code looks good, but you need to make it opt in as it will cause unexpected changes in addons that already use the editbox. |
How about: if type(editboxData.isMultiline) == "number" then
if editboxData.isMultiline <= 1 then -- new single-line style
else -- new multi-line style, use the number to set height
end
else -- old behaviour
end |
I'm not really a fan of multipurpose properties that do not match their name. |
…hen using 'isExtraWide'. simplified 'if' structure
I just pulled your latest changes and get the following error:
AFAIK only AutoInvite uses the settings controls outside of the settings menu (like described in the documentation) and passes a parent that is not a panel, but I would still like to support this case, as minor versions should not break compatibility. I did that once and got a really angry pm as a result. :P Something like Other than that it looks good now. |
changes how editboxes are sized, labels now on top instead of beside editbox; this should make editing longer texts easier. Text should also be aligned better.
-Terrillyn