Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking of binary compatibility #66

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Conversation

plokhotnyuk
Copy link
Contributor

For version numbering the Recommended Versioning Scheme was used.

More info about binary compatibility in Scala:
https://www.youtube.com/watch?v=2wkEX6MCxJs&list=PLl9Aulxh1VePOMT5TCsm7EQAd0dgYkKNt&index=2&t=0s

@codecov-io
Copy link

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   78.91%   78.91%           
=======================================
  Files          59       59           
  Lines        4306     4306           
  Branches      506      506           
=======================================
  Hits         3398     3398           
  Misses        908      908

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f137592...0d372c8. Read the comment docs.

@@ -89,6 +95,43 @@ lazy val commonSettings = Seq(
}
)

lazy val mimaSettings = Seq(
resolvers += "Sonatype OSS Staging" at "https://oss.sonatype.org/content/repositories/staging",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid Travis CI build failure after pushing a new tag during the release, while just released artifacts are not available on the Maven Central repo still.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense.
Thank you!

@sirthias
Copy link
Owner

Cool!
Thank you for this patch!

@sirthias sirthias merged commit a7f9209 into sirthias:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants