Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableCaption Node's start/end indices are not set #175

Closed
vsch opened this issue Aug 20, 2015 · 3 comments
Closed

TableCaption Node's start/end indices are not set #175

vsch opened this issue Aug 20, 2015 · 3 comments

Comments

@vsch
Copy link
Contributor

vsch commented Aug 20, 2015

The TableCaption node is not properly created in the parser resulting in startIndex, endIndex always being zero.

I have a fix and an AST test, here is the result of the new AST test without the fix, it shows the problem well:

[error]          TableCaptionNode [0-0]
[error]            TextNode [604-609] 'Table'
[error]            SpecialTextNode [609-610] ':'
[error]            TextNode [610-618] ' Caption'

Will post PR with a bunch of other parser compatibility and other source range anomalies.
@vsch vsch mentioned this issue Aug 20, 2015
Closed
@sirthias
Copy link
Owner

You rock! :)

vsch added a commit to vsch/pegdown that referenced this issue Aug 22, 2015
@vsch
fix Definition Lists sirthias#180
e040d0a 
fix Escaped Characters for disabled extensions sirthias#179
add StrikeNode has isClosed() member sirthias#178
fix Reference node includes trailing blank lines sirthias#177
fix Setext headers not allowing blanks after --- or === sirthias#176
fix CaptionNode not having source index range set sirthias#175
add ATXHEADERSPACE extension to require a space/tab after # in AtxHeaders sirthias#144
add RELAXEDHRULES extenstion to relax requirement of a blank line after horiz. rule. sirthias#129
fix STRIKETHROUGH extension did not add ~ to special characters. sirthias#131
vsch added a commit to vsch/pegdown that referenced this issue Aug 22, 2015
@vsch
Merge branch 'develop'
5e7a132 
fix Definition Lists sirthias#180
fix Escaped Characters for disabled extensions sirthias#179
add StrikeNode has isClosed() member sirthias#178
fix Reference node includes trailing blank lines sirthias#177
fix Setext headers not allowing blanks after --- or === sirthias#176
fix CaptionNode not having source index range set sirthias#175
add ATXHEADERSPACE extension to require a space/tab after # in AtxHeaders sirthias#144
add RELAXEDHRULES extenstion to relax requirement of a blank line after horiz. rule. sirthias#129
fix STRIKETHROUGH extension did not add ~ to special characters. sirthias#131
@vsch vsch mentioned this issue Aug 22, 2015
Merged
@sirthias
Copy link
Owner

Closed by #181.

@vsch
Copy link
Contributor Author

vsch commented Aug 22, 2015

Thank the plugin. Visually highlighting the range makes finding bugs a piece of cake. I now have a “Debug” scheme in the plugin for myself. It has neon background colours for all the elements so that you can easily see where they start and end.

Best regards,

Vladimir.

On Aug 21, 2015, at 5:43 AM, Mathias notifications@github.com wrote:

You rock! :)

—
Reply to this email directly or view it on GitHub #175 (comment).

@vsch vsch closed this as completed Aug 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirthias @vsch