Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add DisableHTMLEscape flag to json_formatter #524

Closed
wants to merge 1 commit into from

Conversation

@igorsechyn
Copy link

@igorsechyn igorsechyn commented Apr 13, 2017

This will enable logging URLs with special characters like "&" and "%".

HTML escaping support was only however added in go 1.7, so it is not compatible with 1.6 :(

@apremalal
Copy link

@apremalal apremalal commented Aug 1, 2017

Any plans on getting this fixed and merged in to the master?

@apremalal
Copy link

@apremalal apremalal commented Oct 3, 2017

Any update on this issues?

@igorsechyn
Copy link
Author

@igorsechyn igorsechyn commented Oct 3, 2017

I can't really do anything here, since the CI needs to be adjusted to drop go 1.6 support for the tests to pass. The library seems to be abandoned though :(

@ahxxm
Copy link

@ahxxm ahxxm commented Sep 12, 2018

@dgsb @igorsechyn CI now drops support for 1.6.. Can this PR be merged?(after resolve conflict)

@domdom82
Copy link

@domdom82 domdom82 commented Oct 16, 2019

bump for this issue. would be really nice to have this. we are at go 1.13 now btw.

@freeformz
Copy link
Collaborator

@freeformz freeformz commented Oct 17, 2019

@igorsechyn Any interest in rebasing this PR?

@stale stale bot added the stale label Feb 26, 2020
@markphelps markphelps removed the stale label Feb 26, 2020
Repository owner deleted a comment from stale bot Feb 26, 2020
@siller174
Copy link

@siller174 siller174 commented Mar 6, 2020

some news?

@davidraleigh
Copy link
Contributor

@davidraleigh davidraleigh commented Mar 13, 2020

made a pull request that resolved conflicts here:
#1113

markphelps added a commit that referenced this issue Mar 22, 2020
resolved conflicts for DisableHTMLEscape in json_formatter.go pull request #524
@markphelps
Copy link
Collaborator

@markphelps markphelps commented Mar 22, 2020

Fixed in #1113. Thank you @igorsechyn !

@markphelps markphelps closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants