TextFormatter behaviour aligned with stdlib log (fixes #167) #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib `log` adds a newline at the end of a message if none is present,
otherwise does not. Before this change logrus would always add
a newline, resulting in inconsistent behaviour if stdlib log was
replaced with logrus, and a user would e.g. use 'log.printf("test\n")'
|
@dgsb , I've updated the pull request to work with the latest master. Implicit newlines should now work the same as the stdlib. e.g. this prevents the negroni logger middleware from spitting out empty lines when passing logrus instead of the default log. Would you be open to merge this or alternatively have a discussion on how the PR can be improved? |
mkenney
added a commit
to bdlm/log
that referenced
this pull request
Aug 12, 2018
* sirupsen/logrus/pull/664 * sirupsen/logrus/pull/647 * sirupsen/logrus/pull/687 * sirupsen/logrus/pull/685 * sirupsen/logrus/pull/788 (existed previously) This also * updates the string escape logic, all values are now JSON escaped * fixes an issue with internal properties being included in JSON format * adds new fields to unit tests (`data` and `caller`) * minor cleanup of text templates
|
@HectorMalot thanks for your contribution |
ivucica
pushed a commit
to ivucica/bdlm-log
that referenced
this pull request
Sep 28, 2020
* sirupsen/logrus/pull/664 * sirupsen/logrus/pull/647 * sirupsen/logrus/pull/687 * sirupsen/logrus/pull/685 * sirupsen/logrus/pull/788 (existed previously) This also * updates the string escape logic, all values are now JSON escaped * fixes an issue with internal properties being included in JSON format * adds new fields to unit tests (`data` and `caller`) * minor cleanup of text templates
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
TextFormatter behaviour aligned with stdlib log (fixes sirupsen#167)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping to help logrus with a small fix for a long-lived issues (#167). I've made the newline behavior consistent with the standard library log package. The fix to
TextFormatterremoves a single new-line (if present) at the end of the providedEntry.Message. e.g."testmessage\n\n"will become"testmessage\n". This is the same behavior aslog.PrintfAdded a test and confirmed existing tests were passing. The benchmark test shows minor impact (up to 1% increase in ns/op), but happy to discuss more efficient options