Add a redactor mechanism to prevent leaks of credentials and confiden… #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have the system of hooks for implementing modification of the content of a log entry. I don't think we need another registration for a function pointer to alter the content of a log. |
|
@JLugagne just getting back to you. Did you succeed to implement your feature with hooks ? |
|
Thank you @dgsb for getting back, I didn't tried the hook yet but I did succeed by doing my RedactorFormatter based on JSONFormatter, it is working fine, I will try hooks later. |
mkenney
added a commit
to bdlm/log
that referenced
this pull request
Aug 12, 2018
* sirupsen/logrus/pull/664 * sirupsen/logrus/pull/647 * sirupsen/logrus/pull/687 * sirupsen/logrus/pull/685 * sirupsen/logrus/pull/788 (existed previously) This also * updates the string escape logic, all values are now JSON escaped * fixes an issue with internal properties being included in JSON format * adds new fields to unit tests (`data` and `caller`) * minor cleanup of text templates
|
We already have the needed logic in logrus to implement this. |
ivucica
pushed a commit
to ivucica/bdlm-log
that referenced
this pull request
Sep 28, 2020
* sirupsen/logrus/pull/664 * sirupsen/logrus/pull/647 * sirupsen/logrus/pull/687 * sirupsen/logrus/pull/685 * sirupsen/logrus/pull/788 (existed previously) This also * updates the string escape logic, all values are now JSON escaped * fixes an issue with internal properties being included in JSON format * adds new fields to unit tests (`data` and `caller`) * minor cleanup of text templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think It would be nice to have a redactor mechanism to hide credentials and confidentials data to prevent any leaks or compromising data in logs.
Here is a proposition to do it, I'm not sure it fit very well the architecture (as it is at the end of the process on the serialized data) but seems to be working.
I know I could have done it by overriding the JSONFormatter and TextFormatter but as it should be a standard feature (IMHO) I wanted to have it as is.