New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Big Refactor #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creating states.jl - Original code came from - 1d/states.jl - 1d/vehicles.jl - 2d/vehicles.jl
Empty placeholder
- Files from 1d/definitions.jl and 2d/definitions.jl
@raunakbh92 Could you take a look at the agent definition interface I just pushed ? |
Let's merge 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutomotiveDrivingModels.jl Refactor
PR to refactor the structure of the package. Assign yourself to some tasks by editing this description.
For each new folder we should:
New folder structure :
folder
(dependencies)Roadways
(no deps): roadway definition, roadway generation, projections, frenet frameVehicleDefinitions
(no deps): abstract type, interface, current vehicle definitions - Raunakshould not be called vehicles. Further, should we include
bicyclemodel
withCAR
,TRUCK
etcas opposed to being a standalone thing as it is now?
States
(roadways, agent definitions): current states definition and scenes - RaunakVehicleState
andassociated
Base.show
andBase.write
methods?CollisionCheckers
(states, agent definitions): collision checking utilitiesActions
(roadway, states, agent definitions): interface, current action definitionsFeatureExtraction
: current feature extraction tools, helpers function to get neighbors and lane infoDriverModels
(roadway, states, actions, features): interface, current driver modelSimulation
: simulation , callbacksAfter the first pass:
since this is just a refactor nothing should break.
Questions
Vec
?Records
?Notable changes
A lot of files are unused, we should not include them in the refactor. If they might be useful in the short term, just open an issue.
No 1d/2d splitting.
Rename filenames if it is relevant.