Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a write_nnet function to utils.jl #100

Merged
merged 20 commits into from
Jul 3, 2020

Conversation

castrong
Copy link
Collaborator

Added a function write_nnet to utils.jl which writes out a network to a .nnet file. Since the Network object doesn't include upper and lower bounds on the input, we write these to the .nnet file as the maximum and minimum values that a Float16 can take on.

Also added a file write_nnet_test.jl which provides a single test of the write_nnet function.

src/utils/util.jl Outdated Show resolved Hide resolved
@tomerarnon
Copy link
Collaborator

Looks good to me. Ready to merge it you are.

@castrong
Copy link
Collaborator Author

castrong commented Jul 2, 2020

Yeah I'm good to merge it! I don't think I have write access to the repository in order to merge it myself.

@tomerarnon tomerarnon merged commit e43df3b into sisl:master Jul 3, 2020
@castrong castrong deleted the add_write_network branch July 3, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants