Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Change for Bounds #117

Merged
merged 8 commits into from
Jul 17, 2020
Merged

Redo Change for Bounds #117

merged 8 commits into from
Jul 17, 2020

Conversation

castrong
Copy link
Collaborator

@castrong castrong commented Jul 13, 2020

Redo the change in reluplex to apply the maxsens bounds post activation instead of pre-activation. Addresses issue #107.

@tomerarnon
Copy link
Collaborator

Also addresses #70 and #82, which we noted quite some time ago were all caused by the same thing.

@castrong
Copy link
Collaborator Author

I have also added in a tolerance to account for numerical instability in Reluplex. This is associated with issue #90, and fixes an infinite recursion where the same node is repeatedly fixed in Reluplex. Similar numerical stability changes for other algorithms should be added eventually as well.

@tomerarnon tomerarnon merged commit b8b7095 into sisl:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants