Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 1.0. All tests pass #7

Merged
merged 3 commits into from Aug 14, 2018
Merged

Fixes for 1.0. All tests pass #7

merged 3 commits into from Aug 14, 2018

Conversation

rejuvyesh
Copy link
Contributor

contains is now occursin. Not sure whether we should change the API.

@tawheeler
Copy link
Collaborator

Any idea why Travis is failing?

@rejuvyesh
Copy link
Contributor Author

Need to fix .travis.yml.

@rejuvyesh
Copy link
Contributor Author

Now contains is the issue. Works on 1.0 but not on 0.7.

@coveralls
Copy link

coveralls commented Aug 14, 2018

Pull Request Test Coverage Report for Build 101

  • 13 of 13 (100.0%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.2%) to 89.764%

Files with Coverage Reduction New Missed Lines %
src/geom/hyperplanes.jl 1 83.33%
src/quat.jl 2 80.65%
src/coordinate_transforms.jl 2 97.75%
Totals Coverage Status
Change from base Build 87: -1.2%
Covered Lines: 342
Relevant Lines: 381

💛 - Coveralls

@tawheeler
Copy link
Collaborator

Please make a PR for the 0.7 fixes and then make a separate PR for the 1.0 fixes in which the required version number is bumped.

@tawheeler tawheeler merged commit 72ab872 into master Aug 14, 2018
@tawheeler tawheeler deleted the jkg/fixes-1.0 branch August 14, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants