Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to pythontex v0.17 #20

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Conversation

johnnychen94
Copy link
Contributor

Closes #19

This is copied from https://github.com/gpoore/pythontex/blob/master/pythontex/pythontex.sty while keeping the custom pigments for Julia not changed

@mykelk
Copy link
Member

mykelk commented Jan 1, 2020

This looks good! It does the trick. I'm thinking that it is probably more elegant to modify juliaplots.sty so that it takes as input a package option that sets the julia lexer to julia1 or something like that. That way we don't have to include a modified pythontex.sty in this repo. The issue is that juliaplots.sty currently uses the package options to pythontex to set the julia lexer to just julia (rather than julia1, which we want for the book). We want something like this:

\RequirePackage{pythontex}
\makepythontexfamily[pyglexer=julia1]{julia}
\makepythontexfamily[pyglexer=julia1]{jl}
\makepythontexfamily@con[jlcon]{julia}

But have julia1 be a package option to juliaplots.

Feel free to file PRs here and at juliaplots.sty. If you want, I can merge what you have right now. Just let me know.

@johnnychen94
Copy link
Contributor Author

Yes, I was considering the possibility as well, but then I realized that my familiarity with latex doesn't support me to do this. Then I decide to fix the broken pipeline first and leave this enhancement to other contributors.

If you want, I can merge what you have right now. Just let me know.

Since this PR fixes the issue, I'm not considering making any more changes recently. (I really want but due to my lack of time and ability...) So let's just merge this PR, open an issue for removing pythontex.sty, and then rebuild the pipeline in the gitlab repository.

@mykelk @tawheeler If you want, I could give you the privilege to that as well, or transfer the ownership. Thank you for making this template public again!

@mykelk mykelk merged commit ed65ea4 into sisl:master Jan 2, 2020
@johnnychen94 johnnychen94 deleted the jc/pythontex branch January 2, 2020 05:13
@johnnychen94
Copy link
Contributor Author

Thanks for the quick response, the pipeline passes now.

@johnnychen94 johnnychen94 mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline failed
2 participants