Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data provider guild #1582

Merged
merged 7 commits into from
Mar 21, 2023
Merged

Data provider guild #1582

merged 7 commits into from
Mar 21, 2023

Conversation

0xmme
Copy link
Contributor

@0xmme 0xmme commented Mar 21, 2023

I've created a data provider for Guild.xyz according to the proposal #1429 .
I created a group generator for the Sismo Contributor Role in Sismo Guild. Works fine.

@0xmme
Copy link
Contributor Author

0xmme commented Mar 21, 2023

@MartinGbz
I enjoyed working with Sismo, so here's a new data provider for Guild.xyz. :)
For questions you can hmu on discord mme#9065

@MartinGbz
Copy link
Contributor

Hey @mme022 so cool! 🔥 thanks!
I will review it today 🙂

@MartinGbz
Copy link
Contributor

@mme022 I pushed a fix, the foreach function doesn't wait the end of each fetch, while for of yes
I also implemented the union data operator in order to merge data without any duplicates 😉

Great job, I merge it! 🙌

@MartinGbz MartinGbz merged commit fc833ab into sismo-core:main Mar 21, 2023
@MartinGbz
Copy link
Contributor

MartinGbz commented Mar 22, 2023

I pushed 2 small fixes here #1588 & #1589 because the InterfaceSchema wasn't referenced in the Data Providers index and there was a problem in the a name. That's on me, sorry for that.
The guild Data Provider is now available in the Factory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants