Skip to content

Commit

Permalink
compile: Allow empty @group definitions
Browse files Browse the repository at this point in the history
Use case: group information is generated from an external system and
because of synchronization or authorization restrictions some groups
can be empty.

Signed-off-by: Teemu Matilainen <teemu.matilainen@reaktor.fi>
  • Loading branch information
Teemu Matilainen authored and sitaramc committed Nov 10, 2010
1 parent 182b1d0 commit 6eb8558
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/gl-compile-conf
Expand Up @@ -169,13 +169,15 @@ sub parse_conf_line
my ($line, $fragment, $repos_p, $ignored_p) = @_;

# user or repo groups
if ($line =~ /^(@\S+) = (.*)/)
if ($line =~ /^(@\S+) = ?(.*)/)
{
die "$ABRT defining groups is not allowed inside fragments\n"
if $GL_BIG_CONFIG and $fragment ne 'master';
# store the members of each group as hash key. Keep track of when
# the group was *first* created by using $fragment as the *value*
do { $groups{$1}{$_} ||= $fragment } for ( expand_list( split(' ', $2) ) );
# create the group hash even if empty
$groups{$1} = {} unless $groups{$1};
die "$ABRT bad group $1\n" unless $1 =~ $REPONAME_PATT;
}
# repo(s)
Expand Down

0 comments on commit 6eb8558

Please sign in to comment.