security fix for optional ADC (admin-defined command) feature

Thanks to Dylan Simon for catching it...
sitaramc · Feb 13, 2011 · a33f0f8 · a33f0f8
1 parent a10287a
commit a33f0f8
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/gitolite.pm b/src/gitolite.pm
@@ -1058,6 +1058,7 @@ sub shell_out {
 sub try_adc {
     my ($cmd, @args) = split ' ', $ENV{SSH_ORIGINAL_COMMAND};
     if (-x "$GL_ADC_PATH/$cmd") {
+        die "I don't like $cmd\n" if $cmd =~ /\.\./;
         # yes this is rather strict, sorry.
         do { die "I don't like $_\n" unless $_ =~ $ADC_CMD_ARGS_PATT } for ($cmd, @args);
         log_it("$GL_ADC_PATH/$ENV{SSH_ORIGINAL_COMMAND}");