Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle file uploads in Form API #26

Closed
acobster opened this issue Apr 5, 2018 · 2 comments
Closed

Handle file uploads in Form API #26

acobster opened this issue Apr 5, 2018 · 2 comments
Assignees
@sdunham
Milestone
v0.5.0

Comments

@acobster
Copy link
Contributor

acobster commented Apr 5, 2018

No description provided.

@acobster acobster added this to the v1.0-BETA milestone Apr 5, 2018
@acobster acobster self-assigned this Apr 5, 2018
@acobster acobster assigned sdunham and unassigned acobster May 18, 2018
sdunham added a commit that referenced this issue Jun 9, 2018
@sdunham
#26 Added methods to Form\AbstractBase for getting/validating uploade…
3638f5a 
…d files
sdunham added a commit that referenced this issue Jun 9, 2018
@sdunham
#26 Better upload error detection when getting uploaded file value, i…
a6f88ef 
…n addition to validation updates made previously
@sdunham
Copy link
Contributor

sdunham commented Jun 9, 2018 •
edited
Loading

Tasks for this issue:

  • Port file upload functionality from existing project code
  • Code documentation
  • Add better support for file upload error validation
  • Add file upload tests to ConiferTest\FormTest
  • Code review/PR

sdunham added a commit that referenced this issue Jun 9, 2018
@sdunham
#26 Added form file upload tests, and tweaked abstract class to suppo…
6741214 
…rt testability of error messaging
@sdunham sdunham mentioned this issue Jun 13, 2018
Merged
acobster added a commit that referenced this issue Jul 28, 2018
@acobster
#26 document fix
fc7d46b
@acobster
Copy link
Contributor Author

Thanks @sdunham !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdunham sdunham

Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
2 participants
@acobster @sdunham