Add main menu current indication when sub-menu item is current

[Misplon]

Look at enabling the current link underline for a sub-menu parent when a sub-menu link is current.

[charlieapple]

Hi Andrew, I am the user who made this suggestion and you added it to GitHub, which I then subscribed to, so I received this below this morning. It reads like you’ve cracked it but I’ve no idea how to implement it on my site!! Can you help? Or will it be included in the next update anyway in which case I’ll wait. Thanks so much. Tracy On 25 Mar 2019, at 08:40, Andrew Misplon <notifications@github.com <mailto:notifications@github.com>> wrote: Closed #61 <#61> via #67 <#67>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKczfS5KLkDzoQWF1oRtJ8IX1Wbc7Ymlks5vaIt4gaJpZM4bN3Ds>. <https://github.githubassets.com/images/email/message_cards/header.png> <https://github.githubassets.com/images/email/message_cards/avatar.png> <https://github.com/siteorigin/siteorigin-corp> <#61 (comment)> <http://schema.org/> <#61 (comment)> <#61 (comment)> <https://github.com/>

[charlieapple]

Hi Andrew, I am the user who made this suggestion and you added it to GitHub, which I then subscribed to, so I received this below this morning. It reads like you’ve cracked it but I’ve no idea how to implement it on my site!! Can you help? Or will it be included in the next update anyway in which case I’ll wait. Thanks so much. Tracy On 25 Mar 2019, at 08:40, Andrew Misplon <notifications@github.com> wrote: Closed #61 <#61> via #67 <#67>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKczfS5KLkDzoQWF1oRtJ8IX1Wbc7Ymlks5vaIt4gaJpZM4bN3Ds>.

[Misplon]

Hi Tracy

Thanks for your feedback :)

This pull request will be included in the next release of Corp.

[charlieapple]

Excellent! Any ideas when that will be approximately? :) On 25 Mar 2019, at 09:19, Andrew Misplon <notifications@github.com> wrote: Hi Tracy Thanks for your feedback :) This pull request will be included in the next release of Corp. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKczfQKutROjO0ywEkuBNqUCl5b3AnQZks5vaJSKgaJpZM4bN3Ds>.

[Misplon]

Sure. This week :) On Mon, Mar 25, 2019 at 11:23 AM charlieapple <notifications@github.com> wrote:

…

Excellent! Any ideas when that will be approximately? :) On 25 Mar 2019, at 09:19, Andrew Misplon ***@***.***> wrote: Hi Tracy Thanks for your feedback :) This pull request will be included in the next release of Corp. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < #61 (comment)>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AKczfQKutROjO0ywEkuBNqUCl5b3AnQZks5vaJSKgaJpZM4bN3Ds >. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAwKp6QdRtgbcXShChtJQgcG31dIr-CXks5vaJWZgaJpZM4bN3Ds> .

[charlieapple]

That’s amazing!! I’m so excited to see it in action and available for everyone not just a personal customisation so this is great! Thanks so much Andrew and for speedy replies this morning! Best Tracy On 25 Mar 2019, at 09:30, Andrew Misplon <notifications@github.com> wrote: Sure. This week :) On Mon, Mar 25, 2019 at 11:23 AM charlieapple <notifications@github.com> wrote:

Excellent! Any ideas when that will be approximately? :) On 25 Mar 2019, at 09:19, Andrew Misplon ***@***.***> wrote: Hi Tracy Thanks for your feedback :) This pull request will be included in the next release of Corp. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < #61 (comment)>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AKczfQKutROjO0ywEkuBNqUCl5b3AnQZks5vaJSKgaJpZM4bN3Ds >. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAwKp6QdRtgbcXShChtJQgcG31dIr-CXks5vaJWZgaJpZM4bN3Ds> .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKczfUsqAN8kk2AtB1BbejJ6UYOkbftDks5vaJdKgaJpZM4bN3Ds>.

[charlieapple]

Hi Andrew, I’ve seen the update in my dashboard and have updated to the latest version of Corp theme, but it is not showing up on my sub-menu item. Was it included in this release and should be showing? Thanks Tracy On 25 Mar 2019, at 09:30, Andrew Misplon <notifications@github.com> wrote: Sure. This week :) On Mon, Mar 25, 2019 at 11:23 AM charlieapple <notifications@github.com> wrote:

Excellent! Any ideas when that will be approximately? :) On 25 Mar 2019, at 09:19, Andrew Misplon ***@***.***> wrote: Hi Tracy Thanks for your feedback :) This pull request will be included in the next release of Corp. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < #61 (comment)>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AKczfQKutROjO0ywEkuBNqUCl5b3AnQZks5vaJSKgaJpZM4bN3Ds >. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAwKp6QdRtgbcXShChtJQgcG31dIr-CXks5vaJWZgaJpZM4bN3Ds> .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKczfUsqAN8kk2AtB1BbejJ6UYOkbftDks5vaJdKgaJpZM4bN3Ds>.

[Misplon]

Hi, it was. Please, send a link to the site and we'll take a look.

[charlieapple]

Thanks Andrew - it’s https://theangelstouch.co.uk/ <https://theangelstouch.co.uk/> On 29 Mar 2019, at 10:55, Andrew Misplon <notifications@github.com> wrote: Hi, it was. Please, send a link to the site and we'll take a look. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKczfUX_kLSM4Zwa0kaqS9-l_0QjkdmCks5vbfEkgaJpZM4bN3Ds>.

[Misplon]

Thanks, try adding to Customize > Additional CSS:

.current-menu-ancestor > a {
    border-bottom: 2px solid #ae69a7 !important;
}

After the next update this rule can be removed.

We were testing with page parents, your menu is using a custom link as the parent so the markup is a bit different.

[charlieapple]

Fantastic Andrew!!! That’s great - thank you very much. I understand what you’ve said below also, that’s great. It’s very satisfying to see that working :) On 29 Mar 2019, at 11:10, Andrew Misplon <notifications@github.com> wrote: Thanks, try adding to Customize > Additional CSS: .current-menu-ancestor > a { border-bottom: 2px solid #ae69a7 !important; } After the next update this rule can be removed. We were testing with page parents, your menu is using a custom link as the parent so the markup is a bit different. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKczfWAMnME01ooXSUtzWWwkiTunG5Y-ks5vbfSSgaJpZM4bN3Ds>.

[Misplon]

Thanks again for your help :) Cheers for now.