-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling in CSS instead of attribute #41
Comments
Hi Adrian You're definitely right here. Using inline styles was much easier to implement, but I'd like to change this to separate CSS. I'll keep you posted on when we start with this. |
Moved CSS out of style attributes, into general layout CSS. Resolves GH-41
This is resolved by f147c61 - we'll merge this in time for the Page Builder 2.5 release. |
@gregpriday fantastic |
@gregpriday sorry to bother you again but I think this does not work when layout is set as full width.
so once the layout is changed from standard to full width, there is still an inline style for that row. Is this intentional? can this be like other rows and have the style in the header? thanks |
Yeah, that's added by Javascript.
…On Thu, Apr 13, 2017 at 6:28 PM, LittleHamster ***@***.***> wrote:
@gregpriday <https://github.com/gregpriday> sorry to bother you again but
I think this does not work when layout is set as full width.
example
<div class="siteorigin-panels-stretch panel-row-style..." data-stretch-type="full" style=".....">
so once the layout is changed from standard to full width, there is still
an inline style for that row. Is this intentional? can this be like other
rows and have the style in the header? thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABExy8ov4tfGuWRqXHvQQnJcBo5-CUQgks5rvk1JgaJpZM4Dm-68>
.
--
I make free WordPress themes
http://siteorigin.com
|
I think it will be better if styling of the element is in the generated CSS instead of the style attribute.
Is there any reason of being in the elements?
The text was updated successfully, but these errors were encountered: