Only run scripts that needs privileges in Firefox. (#1558)

* Only run scripts that needs privileges in Firefox. #1557 * requires are never an array
sitespeedio · Apr 26, 2021 · 6b270ee · 6b270ee
1 parent 740989f
commit 6b270ee
Showing 1 changed file with 17 additions and 10 deletions.
diff --git a/lib/core/seleniumRunner.js b/lib/core/seleniumRunner.js
@@ -599,10 +599,11 @@ class SeleniumRunner {
   async runScriptInCategory(category, isAsync) {
     const scriptNames = Object.keys(category);
     const results = {};
-    let requires = [];
+    let requires;
 
     for (let scriptName of scriptNames) {
       let isAsyncOverride = false;
+      requires = {};
       let script = category[scriptName];
 
       if (typeof script != 'string') {
@@ -629,15 +630,21 @@ class SeleniumRunner {
         requires = category[scriptName].requires;
         isAsyncOverride = category[scriptName].isAsync;
       }
-
-      const result = await this.runScriptFromCategory(
-        script,
-        isAsync || isAsyncOverride,
-        scriptName,
-        requires
-      );
-      if (!(result === null || result === undefined)) {
-        results[scriptName] = result;
+      if (
+        Object.keys(requires).length > 0 &&
+        this.options.browser !== 'firefox'
+      ) {
+        // Require is only for running in Firefox
+      } else {
+        const result = await this.runScriptFromCategory(
+          script,
+          isAsync || isAsyncOverride,
+          scriptName,
+          requires
+        );
+        if (!(result === null || result === undefined)) {
+          results[scriptName] = result;
+        }
       }
     }
     return results;