Only run scripts that needs privileges in Firefox. #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gmierz put you on review FYI but gonna merge asap :) This has been broken since we merged it: The appconstants script that needs privileges breaks the "browser" scripts in other browsers than Firefox (we miss it in the output.json). A couple of levels down we do a check for Firefox and then throws and error https://github.com/sitespeedio/browsertime/blob/main/lib/core/seleniumRunner.js#L390-L395 and that is swallow, not seen. With this fix all scripts in the browser category will work in all browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1557