Add an option to prevent browsertime from setting Firefox default preferences. #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @soulgalore! We have an issue where our prefs are being overriden by the settings in browsertime - this patch would let us prevent that. |
|
Hi @gmierz aha cool, what about changing the name to |
soulgalore
reviewed
Oct 6, 2021
lib/support/cli.js
Outdated
| @@ -483,6 +483,12 @@ module.exports.parseCommandLine = function parseCommandLine() { | |||
| type: 'boolean', | |||
| group: 'firefox' | |||
| }) | |||
| .option('firefox.noPrefs', { | |||
There was a problem hiding this comment.
Thinking noDefaultPrefs maybe is a little better?
|
If you can fix that, I'll can add the same config to Chrome too :) |
|
Sounds good to me thanks! :) |
gmierz
commented
Oct 6, 2021
soulgalore
approved these changes
Oct 6, 2021
|
Thank you @gmierz :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an option (--firefox.noPrefs) that lets us prevent browsertime from setting default preferences. This solves an issue where settings in an existing profile get overriden by the preferences set in browsertime.