Added --experimental.dumpChromeNetlog #274
Conversation
|
There seems to be an issue that the log is not entirely written and truncated. |
lib/core/engine.js
Outdated
| @@ -124,6 +124,15 @@ class Engine { | |||
| options.postScript.unshift(...videoPostScripts); | |||
| } | |||
|
|
|||
| if(options.experimental.dumpChromeNetlog) { | |||
There was a problem hiding this comment.
Can you change that to use lodash.get or add an extra if, yargs doesn't populate experimental so it will try .dumpChromeNetlog on an undefined object if you don't send any experimental arguments. same in chrome.js.
Ok so it's unusable? |
|
Yes, it seems to be an issue with the chromedriver, waiting for replies here: https://groups.google.com/forum/#!topic/chromedriver-users/T5uxtJ3kKuU |
|
Seems to be an issue in Chromedriver: |
|
Maybe we can fix it temporary by sending all the default settings to Chromedriver as the answer in your bug report just so you get the info you need? |
|
there is now a fix available, i guess it will land in chromedriver 2.28. There still seems to be an related issue with windows, but im not sure if that is concerning us at all. If i manage to find some time im gonna recompile chromium and test the patch it with browsertime over the weekend |
|
@worenga we use the 2.28 in master, do you have time to test if it works? |
worenga
force-pushed
the
chrome-dump-netlog
branch
from
95d6436
to
0ec665b
Compare
|
yes, the log ins no longer truncated in the new chromedriver, rebased pr |
|
🎉 🎉 🎉 |
No description provided.